Add REPORTF test macro.

tests/Test.h

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef skiatest_Test_DEFINED
 #define skiatest_Test_DEFINED
 
@@ skipping 89 matching lines @@
 
 #define REPORTER_ASSERT_MESSAGE(r, cond, message)                            \
     do {                                                                     \
         if (!(cond)) {                                                       \
             SkString desc;                                                   \
             desc.printf("%s %s:%d: %s", message, __FILE__, __LINE__, #cond); \
             r->reportFailed(desc);                                           \
         }                                                                    \
     } while(0)
 
+#define REPORTF(REPORTER, PRINTF_ARGS)                 \

[mtklein, 2014/01/10 14:03:58]

Generally, arguments to macros don't need to be capitalized themselves.  I don't
mind it though if you want to keep it.

[mtklein, 2014/01/10 14:03:58]

If you write this as

#define REPORTF(REPORTER, ...)
  do {
    SkString message;
    message.printf(__VA_ARGS__);
    ...
  } while(0)

both the macro and the calling code look cleaner.  Despite not being standard
until C++11, VA_ARGS is supported by essentially ever compiler, including all
the ones we even vaguely care about.  (It's already used in Skia codebase.)

[hal.canary, 2014/01/10 14:50:31]

Done.

[hal.canary, 2014/01/10 14:50:31]

Done.

+    do {                                               \
+        SkString message;                              \
+        message.printf PRINTF_ARGS ;                   \
+        message.appendf(" %s:%d", __FILE__, __LINE__); \

[mtklein, 2014/01/10 14:03:58]

I'd prefer file:line to come first.  It's nice to be able to look for them at a
fixed column (0), and most other log tools put them there too.

[hal.canary, 2014/01/10 14:50:31]

Done.

+        (REPORTER)->reportFailed(message);             \

[mtklein, 2014/01/10 14:03:58]

We may want to follow up and make reportFailed more generic report-y and less
fail-y.  It currently prints FAILED: <msg> in tests.  It just doesn't seem like
all REPORTF calls will be failures, no?

On the other hand, if all REPORTF calls _will_ be some sort of failure, maybe
ERRORF?

[hal.canary, 2014/01/10 14:50:31]

Done.

+    } while(0)
 
 #endif