Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1328423003: Don't skip asan tests with atypical exit status. (Closed)

Created:
5 years, 3 months ago by bbudge
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Don't skip asan tests with atypical exit status. Atypical exit codes cause asan tests to be skipped. In particular the asan_test sanity check is skipped. Add more asan options to tests so all tests run with expected results. BUG= Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6a00337da3b31147e8770d8fa7d8309d41feca52

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M SConstruct View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/unittests/trusted/asan/build.scons View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
bbudge
My previous change causes asan_test to be skipped. This CL adds more ASan options. I ...
5 years, 3 months ago (2015-09-11 01:11:21 UTC) #12
Roland McGrath
lgtm
5 years, 3 months ago (2015-09-11 18:24:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328423003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328423003/220001
5 years, 3 months ago (2015-09-11 19:40:22 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 19:42:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:220001) as
https://chromium.googlesource.com/native_client/src/native_client/+/6a00337da...

Powered by Google App Engine
This is Rietveld 408576698