Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 1328363002: [turbofan] Make %Arguments composable with inlining. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make %Arguments composable with inlining. This makes the C++ fallback implementations for the two intrinsics, %Arguments and %ArgumentsLength composable with respect to inlining. Using deoptimization information gives us accurate data here. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-4374 BUG=v8:4374 LOG=n Committed: https://crrev.com/a504a184f64a97aa75213649b1fcad2b5a60910a Cr-Commit-Position: refs/heads/master@{#30654}

Patch Set 1 #

Patch Set 2 : Fix compilation on GCC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -31 lines) Patch
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/runtime/runtime-function.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 3 chunks +17 lines, -19 lines 0 comments Download
A test/mjsunit/regress/regress-4374.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-09 13:38:08 UTC) #1
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-09-09 13:39:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328363002/20001
5 years, 3 months ago (2015-09-09 14:07:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 14:14:08 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a504a184f64a97aa75213649b1fcad2b5a60910a Cr-Commit-Position: refs/heads/master@{#30654}
5 years, 3 months ago (2015-09-09 14:14:28 UTC) #7
Michael Achenbach
5 years, 3 months ago (2015-09-10 09:41:35 UTC) #9
Message was sent while issue was closed.
Could you revisit this? This makes two tests much slower. They run now sometimes
into timeouts on asan.

Compare before:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/5242/steps/C...
After your patch:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/5243/steps/C...

00:45:968 mjsunit/es6/string-fromcodepoint
00:41:020 mjsunit/string-indexof-1

Powered by Google App Engine
This is Rietveld 408576698