Do not crash when out of memory at ImageData::create().

Do not crash when out of memory at ImageData::create().

The old implementation was "allocate or die".  It's not good for
ImageData, which may try to allocate a huge memory block.  This CL
makes ImageData gracefully returns nullptr optionally raising an
exception in case of out of memory.

BUG=528898
Committed: https://crrev.com/bb2036fb19514a807ef2734b65d4b9b1df17ae6a
git-svn-id: svn://svn.chromium.org/blink/trunk@201982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Yuki, 2015-09-09 09:14:38]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2015-09-09 09:14:38]

Could you review this CL?

[haraken, 2015-09-09 09:23:55]

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData.cpp
File Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData....
Source/core/html/ImageData.cpp:90:
exceptionState.throwDOMException(V8GeneralError, "Out of memory at ImageData
creation");

What error does Firefox or IE throw for this case?

Given that we're throwing IndexSizeError for an invalid width and height,
IndexSizeError might make more sense here as well.

[Yuki, 2015-09-09 09:31:30]

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData.cpp
File Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData....
Source/core/html/ImageData.cpp:90:
exceptionState.throwDOMException(V8GeneralError, "Out of memory at ImageData
creation");
On 2015/09/09 09:23:55, haraken wrote:
> 
> What error does Firefox or IE throw for this case?
> 
> Given that we're throwing IndexSizeError for an invalid width and height,
> IndexSizeError might make more sense here as well.

I failed to make Firefox throw an exception, but I'll try it again.

The spec explicitly requires that ImageData throws IndexSizeError in case of
the invalid range of size.  The error is not designed for out of memory.  Out
of memory error can happen even if the size is valid.  Should be distinguished
one from another.  (Actually we check the range first and throw in the case.)

Anyway, I'll try to check other browser's behaviors.

[Yuki, 2015-09-09 12:50:10]

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData.cpp
File Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/1328343002/diff/1/Source/core/html/ImageData....
Source/core/html/ImageData.cpp:90:
exceptionState.throwDOMException(V8GeneralError, "Out of memory at ImageData
creation");
On 2015/09/09 09:31:30, Yuki wrote:
> On 2015/09/09 09:23:55, haraken wrote:
> > 
> > What error does Firefox or IE throw for this case?
> > 
> > Given that we're throwing IndexSizeError for an invalid width and height,
> > IndexSizeError might make more sense here as well.
> 
> I failed to make Firefox throw an exception, but I'll try it again.
> 
> The spec explicitly requires that ImageData throws IndexSizeError in case of
> the invalid range of size.  The error is not designed for out of memory.  Out
> of memory error can happen even if the size is valid.  Should be distinguished
> one from another.  (Actually we check the range first and throw in the case.)
> 
> Anyway, I'll try to check other browser's behaviors.

As far as I tested with Firefox on GNU/Linux, Firefox does not respond...
Something bad seems happening in it.

[haraken, 2015-09-09 13:34:36]

LGTM

[Yuki, 2015-09-09 14:47:07]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-09-09 14:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328343002/1

[commit-bot: I haz the power, 2015-09-09 16:02:30]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201982

[commit-bot: I haz the power, 2015-09-23 12:00:18]

Patchset 1 (id:??) landed as
https://crrev.com/bb2036fb19514a807ef2734b65d4b9b1df17ae6a