Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1328313002: Disable the extension service worker checks that are crashing the renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disable some tests as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/service_worker_apitest.cc
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 9dd77255554ab81a71fc5ad648ac767311ecd512..c38e09958c68a0214f82f4ff3203208404cabdb7 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -43,7 +43,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, CannotRegisterServiceWorkersOnDev) {
listener.message());
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, ServiceWorkerFetchEvent) {
+// Disabled: crbug.com/529516.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, DISABLED_ServiceWorkerFetchEvent) {
Devlin 2015/09/09 15:35:00 :( Were these flaky?
Devlin 2015/09/09 15:35:44 I guess I should have read the email that came in
RunExtensionTest("service_worker/fetch");
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -67,7 +68,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, ServiceWorkerFetchEvent) {
// Binding that was created on the v8::Context of the worker for testing
// purposes should bind an object to chrome.
-IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, ServiceWorkerChromeBinding) {
+// Disabled: crbug.com/529516.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, DISABLED_ServiceWorkerChromeBinding) {
ASSERT_TRUE(RunExtensionTest("service_worker/bindings")) << message_;
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -89,7 +91,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, ServiceWorkerChromeBinding) {
EXPECT_EQ("object", output);
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, GetBackgroundClient) {
+// Disabled: crbug.com/529516.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, DISABLED_GetBackgroundClient) {
ASSERT_TRUE(RunExtensionTest("service_worker/background_client")) << message_;
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
« no previous file with comments | « no previous file | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698