Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1328313002: Disable the extension service worker checks that are crashing the renderer. (Closed)

Created:
5 years, 3 months ago by not at google - send to devlin
Modified:
5 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the extension service worker checks that are crashing the renderer. They're triggering for hosted apps, which is a bug. It's still not correct and that will be fixed soon, but in the meantime don't crash. BUG=525965, 529516 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/881d73aac25304b2fc310ba2a63ac2abd4a0cdfc Cr-Commit-Position: refs/heads/master@{#347859}

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : disable some tests as well #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M chrome/browser/extensions/service_worker_apitest.cc View 1 2 3 chunks +6 lines, -3 lines 2 comments Download
M extensions/renderer/dispatcher.cc View 1 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
not at google - send to devlin
5 years, 3 months ago (2015-09-09 00:00:23 UTC) #2
Devlin
lgtm
5 years, 3 months ago (2015-09-09 00:24:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328313002/40001
5 years, 3 months ago (2015-09-09 00:28:35 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-09 08:58:54 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/881d73aac25304b2fc310ba2a63ac2abd4a0cdfc Cr-Commit-Position: refs/heads/master@{#347859}
5 years, 3 months ago (2015-09-09 08:59:52 UTC) #8
Devlin
https://codereview.chromium.org/1328313002/diff/40001/chrome/browser/extensions/service_worker_apitest.cc File chrome/browser/extensions/service_worker_apitest.cc (right): https://codereview.chromium.org/1328313002/diff/40001/chrome/browser/extensions/service_worker_apitest.cc#newcode47 chrome/browser/extensions/service_worker_apitest.cc:47: IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, DISABLED_ServiceWorkerFetchEvent) { :( Were these flaky?
5 years, 3 months ago (2015-09-09 15:35:00 UTC) #9
Devlin
5 years, 3 months ago (2015-09-09 15:35:44 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1328313002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/service_worker_apitest.cc (right):

https://codereview.chromium.org/1328313002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/service_worker_apitest.cc:47:
IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, DISABLED_ServiceWorkerFetchEvent) {
On 2015/09/09 15:35:00, Devlin wrote:
> :( Were these flaky?

I guess I should have read the email that came in right after this... (yes, they
were flaky)

Powered by Google App Engine
This is Rietveld 408576698