Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/telemetry/telemetry/internal/story_runner_unittest.py

Issue 1328303004: [Android][telemetry] Break logging deadlock in AppCrashException. (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed desktop_browser_backend Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/internal/story_runner_unittest.py b/tools/telemetry/telemetry/internal/story_runner_unittest.py
index 7ea3e1508e9a7ba7a89dcf07ae313247c2121f99..e7f8b88a8865367bfaecfb3542f720028f7f0657 100644
--- a/tools/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/tools/telemetry/telemetry/internal/story_runner_unittest.py
@@ -351,7 +351,7 @@ class StoryRunnerTest(unittest.TestCase):
story_set = story_module.StorySet()
class SharedStoryThatCausesAppCrash(TestSharedPageState):
def WillRunStory(self, story):
- raise exceptions.AppCrashException('App Foo crashes')
+ raise exceptions.AppCrashException(msg='App Foo crashes')
story_set.AddStory(DummyLocalStory(
SharedStoryThatCausesAppCrash))
@@ -409,7 +409,8 @@ class StoryRunnerTest(unittest.TestCase):
old_run_count = self.run_count
self.run_count += 1
if old_run_count == 0:
- raise exceptions.BrowserGoneException('i am a browser instance')
+ raise exceptions.BrowserGoneException(
+ None, 'i am a browser crash message')
def ValidateAndMeasurePage(self, page, tab, results):
pass
« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698