Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: tools/telemetry/telemetry/core/exceptions.py

Issue 1328303004: [Android][telemetry] Break logging deadlock in AppCrashException. (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed desktop_browser_backend Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/exceptions.py
diff --git a/tools/telemetry/telemetry/core/exceptions.py b/tools/telemetry/telemetry/core/exceptions.py
index 9882f458aa9ea9f45adfb19cb88fa7cd1b621c2f..c296a836565ec1e9d4b1fa7e0a6313e97b1a62fc 100644
--- a/tools/telemetry/telemetry/core/exceptions.py
+++ b/tools/telemetry/telemetry/core/exceptions.py
@@ -53,16 +53,16 @@ class TimeoutException(Error):
class AppCrashException(Error):
def __init__(self, app=None, msg=''):
super(AppCrashException, self).__init__(msg)
- self._app = app
self._msg = msg
+ self._stack_trace = app.GetStackTrace() if app else None
def __str__(self):
- if not self._app:
+ if not self._stack_trace:
return super(AppCrashException, self).__str__()
divider = '*' * 80
return '%s\nStack Trace:\n%s\n\t%s\n%s' % (
super(AppCrashException, self).__str__(), divider,
- self._app.GetStackTrace().replace('\n', '\n\t'), divider)
+ self._stack_trace.replace('\n', '\n\t'), divider)
class DevtoolsTargetCrashException(AppCrashException):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698