Issue 1328303002: fix implicit_scope_test and builtin_identifier_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328303002: fix implicit_scope_test and builtin_identifier_test (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly

Modified:
5 years, 3 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

fix implicit_scope_test and builtin_identifier_test these were generating invalid JS code R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6af5d39ca23dd3a4e1b91fe417e5cb4a269c7bfe

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -15 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	1	4 chunks	+24 lines, -7 lines	0 comments	Download
M	lib/src/codegen/js_names.dart	View		4 chunks	+15 lines, -3 lines	0 comments	Download
M	lib/src/js/nodes.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/src/js/printer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/browser/language_tests.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/codegen/language/built_in_identifier_test.dart	View		1 chunk	+116 lines, -0 lines	0 comments	Download
A	test/codegen/language/implicit_scope_test.dart	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	test/codegen_test.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 3 months ago (2015-09-08 23:56:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6af5d39ca23dd3a4e1b91fe417e5cb4a269c7bfe (presubmit successful).