Allow turning on selection painting without selection gaps via window.internals.

Allow turning on selection painting without selection gaps via window.internals.

BUG=474759
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201943

[wkorman, 2015-09-08 22:55:54]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[wkorman, 2015-09-08 22:55:54]

We need this to write tests for the new selection gap painting in advance of
actually turning the feature on in all layout tests.

pdr@ said there was an auto-generated setter for Blink RuntimeEnabledFeatures,
but I didn't find one. He pointed me to:

window.internals.settings.setTextAutosizingEnabled(true);

and I see this:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

which doesn't look auto-generated and looks like it exposes things more broadly
than we need, so I'm following what I did in past for setting caps lock state,
but if I should do this via WebSettings instead let me know.

[chrishtr, 2015-09-08 22:59:02]

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.h (right):

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.h:376: void
setSelectionPaintingWithoutSelectionGaps(bool enabled);
setSelectionPaintingWithoutSelectionGapsEnabled

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.idl:341: // Allows setting whether selection
painting should include selection gaps.
You don't need this comment, it doesn't really add anything IMO.

[pdr., 2015-09-08 23:01:01]

LGTM, I don't see one either.

I'd take everything that guy says with a grain of salt.

[wkorman, 2015-09-08 23:08:38]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2015-09-08 23:08:38]

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.h (right):

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.h:376: void
setSelectionPaintingWithoutSelectionGaps(bool enabled);
On 2015/09/08 at 22:59:02, chrishtr wrote:
> setSelectionPaintingWithoutSelectionGapsEnabled

Done.

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1328293002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.idl:341: // Allows setting whether selection
painting should include selection gaps.
On 2015/09/08 at 22:59:02, chrishtr wrote:
> You don't need this comment, it doesn't really add anything IMO.

Done.

[wkorman, 2015-09-08 23:08:38]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1328293002/#ps20001
(title: "Integrate feedback.")

[commit-bot: I haz the power, 2015-09-08 23:08:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328293002/20001

[commit-bot: I haz the power, 2015-09-09 00:18:47]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201943