Issue 1328283003: Avoid implicit conversion from Rect to RectF in events and gfx tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328283003: Avoid implicit conversion from Rect to RectF in events and gfx tests. (Closed)

Created:
5 years, 3 months ago by danakj

Modified:
5 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, cc-bugs_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org, piman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid implicit conversion from Rect to RectF in events and gfx tests. TBR=sky BUG=342848 Committed: https://crrev.com/dd7e2cf27da44f5af1c545ef6fe92408233f118f Cr-Commit-Position: refs/heads/master@{#347801}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	ui/gfx/geometry/rect_unittest.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328283003/1

5 years, 3 months ago (2015-09-08 21:14:28 UTC) #3

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 21:56:16 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dd7e2cf27da44f5af1c545ef6fe92408233f118f
Cr-Commit-Position: refs/heads/master@{#347801}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages