MD Downloads: remove malware nodes from DOM if a download isn't malware

chrome/browser/resources/md_downloads/item.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   var Item = Polymer({
     is: 'downloads-item',
 
     /**
      * @param {!downloads.ThrottledIconLoader} iconLoader
@@ skipping 17 matching lines @@
       readyPromise: {
         type: Object,
         value: function() {
           return new Promise(function(resolve, reject) {
             this.resolveReadyPromise_ = resolve;
           }.bind(this));
         },
       },
 
       scrollbarWidth: {
+        observer: 'onScrollbarWidthChange_',
         type: Number,
         value: 0,
-        observer: 'onScrollbarWidthChange_',
       },
 
       completelyOnDisk_: {
+        computed: 'computeCompletelyOnDisk_(' +
+            'data_.state, data_.file_externally_removed)',
         type: Boolean,
         value: true,
-        computed: 'computeCompletelyOnDisk_(' +
-            'data_.state, data_.file_externally_removed)',
       },
 
       i18n_: {
+        readOnly: true,
         type: Object,
         value: function() {
           return {
             cancel: loadTimeData.getString('controlCancel'),
+            discard: loadTimeData.getString('dangerDiscard'),
             pause: loadTimeData.getString('controlPause'),
+            remove: loadTimeData.getString('controlRemoveFromList'),
             resume: loadTimeData.getString('controlResume'),
+            restore: loadTimeData.getString('dangerRestore'),
             retry: loadTimeData.getString('controlRetry'),
+            save: loadTimeData.getString('dangerSave'),
             show: loadTimeData.getString('controlShowInFolder'),
           };
         },
-        readOnly: true,
       },
 
       isDangerous_: {
+        computed: 'computeIsDangerous_(data_.state)',
         type: Boolean,
         value: false,
-        computed: 'computeIsDangerous_(data_.state)',
       },
 
       isInProgress_: {
+        computed: 'computeIsInProgress_(data_.state)',
         type: Boolean,
         value: false,
-        computed: 'computeIsInProgress_(data_.state)',
       },
 
       showCancel_: {
+        computed: 'computeShowCancel_(data_.state)',
         type: Boolean,
         value: false,
-        computed: 'computeShowCancel_(data_.state)',
       },
 
       showProgress_: {
+        computed: 'computeShowProgress_(showCancel_, data_.percent)',
         type: Boolean,
         value: false,
-        computed: 'computeShowProgress_(showCancel_, data_.percent)',
       },
 
-      /** Only set when |isDangerous| is true. */
-      isMalware_: Boolean,
+      isMalware_: {
+        computed: 'computeIsMalware_(isDangerous_, data_.danger_type)',
+        type: Boolean,
+        value: false,
+      },
 
       // TODO(dbeam): move all properties to |data_|.
       data_: {
         type: Object,
         value: function() { return {}; },
       },
     },
 
     ready: function() {
       this.content = this.$.content;
@@ skipping 47 matching lines @@
 
       // Status goes in the "tag" (next to the file name) if there's no file.
       this.ensureTextIs_(this.$.description, isActive ? description : '');
       this.ensureTextIs_(this.$.tag, isActive ? '' : description);
 
       this.$.content.classList.toggle('show-progress', this.showProgress_);
 
       var hideRemove;
 
       if (this.isDangerous_) {
-        this.isMalware_ =
-            data.danger_type == downloads.DangerType.DANGEROUS_CONTENT ||
-            data.danger_type == downloads.DangerType.DANGEROUS_HOST ||
-            data.danger_type == downloads.DangerType.DANGEROUS_URL ||
-            data.danger_type == downloads.DangerType.POTENTIALLY_UNWANTED;
         hideRemove = true;
       } else {
         this.$['file-link'].href = data.url;
         this.ensureTextIs_(this.$['file-link'], data.file_name);
 
         this.$['file-link'].hidden = !this.completelyOnDisk_;
         this.$.name.hidden = this.completelyOnDisk_;
 
         hideRemove = this.showCancel_ ||
             !loadTimeData.getBoolean('allowDeletingHistory');
@@ skipping 25 matching lines @@
       assert(!this.hideDate);
       return assert(this.data_.since_string || this.data_.date_string);
     },
 
     /** @private */
     computeIsInProgress_: function() {
       return this.data_.state == downloads.States.IN_PROGRESS;
     },
 
     /** @private */
+    computeIsMalware_: function() {
+      return this.isDangerous_ &&
+          (this.data_.danger_type == downloads.DangerType.DANGEROUS_CONTENT ||
+           this.data_.danger_type == downloads.DangerType.DANGEROUS_HOST ||
+           this.data_.danger_type == downloads.DangerType.DANGEROUS_URL ||
+           this.data_.danger_type == downloads.DangerType.POTENTIALLY_UNWANTED);
+    },
+
+    /** @private */
     computeIsDangerous_: function() {
       return this.data_.state == downloads.States.DANGEROUS;
     },
 
     /** @private */
     computeShowCancel_: function() {
       return this.data_.state == downloads.States.IN_PROGRESS ||
              this.data_.state == downloads.States.PAUSED;
     },
 
@@ skipping 138 matching lines @@
     },
 
     /** @private */
     onShowClick_: function() {
       this.actionService_.show(this.data_.id);
     },
   });
 
   return {Item: Item};
 });