chromeos/network/network_connection_handler_unittest.cc - Issue 1328233002: Ramove use of JSONReader::DeprecatedRead from chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_connection_handler_unittest.cc

Issue 1328233002: Ramove use of JSONReader::DeprecatedRead from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/auto_connect_handler_unittest.cc ('K') | « chromeos/network/client_cert_resolver_unittest.cc ('k') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('j') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/network_connection_handler_unittest.cc

diff --git a/chromeos/network/network_connection_handler_unittest.cc b/chromeos/network/network_connection_handler_unittest.cc

index c36cb1e16ad6011fa33df93909929f05cc530272..f4d2b15448406d12bd1fa898b92def29e1c7bac8 100644

--- a/chromeos/network/network_connection_handler_unittest.cc

+++ b/chromeos/network/network_connection_handler_unittest.cc

@@ -274,10 +274,10 @@ class NetworkConnectionHandlerTest : public testing::Test {

const base::DictionaryValue& global_config,

bool user_policy) {

std::string error;

- scoped_ptr<base::Value> network_configs_value(

- base::JSONReader::DeprecatedReadAndReturnError(

- network_configs_json, base::JSON_ALLOW_TRAILING_COMMAS, nullptr,

- &error));

+ scoped_ptr<base::Value> network_configs_value =

+ base::JSONReader::ReadAndReturnError(network_configs_json,

+ base::JSON_ALLOW_TRAILING_COMMAS,

+ nullptr, &error);

ASSERT_TRUE(network_configs_value) << error;

base::ListValue* network_configs = nullptr;