Ramove use of JSONReader::DeprecatedRead from chromeos/

Ramove use of JSONReader::DeprecatedRead from chromeos/

Remove use of deprecated function DeprecatedRead from chromeos/

BUG=523194
Committed: https://crrev.com/c6c44b1595e0a35dd9afe43fc50f5f54c0c13614
Cr-Commit-Position: refs/heads/master@{#348103}

[Olli Raula, 2015-09-08 13:48:32]

olli.raula@intel.com changed reviewers:
+ oshima@chromium.org

[Olli Raula, 2015-09-08 13:48:45]

Could you review?

[oshima, 2015-09-08 14:45:58]

lgtm

[Olli Raula, 2015-09-09 06:25:44]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-09-09 06:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328233002/1

[commit-bot: I haz the power, 2015-09-09 06:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 06:38:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Olli Raula, 2015-09-09 06:45:30]

olli.raula@intel.com changed reviewers:
+ pneubeck@chromium.org

[Olli Raula, 2015-09-09 06:46:27]

pneubeck: Could you review chromeos/network

[pneubeck (no reviews), 2015-09-09 11:49:51]

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/auto_conne...
File chromeos/network/auto_connect_handler_unittest.cc (right):

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/auto_conne...
chromeos/network/auto_connect_handler_unittest.cc:221:
ASSERT_TRUE(network_configs_value.get()) << error;
it's common to drop the ".get()" for boolean checks.

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/auto_conne...
chromeos/network/auto_connect_handler_unittest.cc:224:
network_configs_value.release()->GetAsList(&network_configs_list));
can you do the release after we ensured that network_configs_value is a
ListValue?
Something like:

ASSERT_TRUE(network_configs_value->GetAsList(&network_configs_list));
network_configs_value.release();
network_configs.reset(network_configs_list);

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/onc/onc_tr...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/onc/onc_tr...
chromeos/network/onc/onc_translator_shill_to_onc.cc:36: value =
make_scoped_ptr(new base::StringValue(str));
shouldn't this be

value.reset(new ...)
?

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/onc/onc_tr...
chromeos/network/onc/onc_translator_shill_to_onc.cc:40: return value;
this must keep the type check:

if (value && value->GetType() != type)
  return nullptr;

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/onc/onc_ut...
File chromeos/network/onc/onc_utils.cc (right):

https://codereview.chromium.org/1328233002/diff/1/chromeos/network/onc/onc_ut...
chromeos/network/onc/onc_utils.cc:55: if (!root.get() ||
!root.release()->GetAsDictionary(&dict_ptr)) {
it's common to drop the ".get()" for boolean checks.

this leaks memory in when root was not a dictionary:
 root.release() gives up ownership
 and GetAsDictionary assigns nullptr to dict_ptr,
 thus the orginal root is leaked.

please instead change to

base::DictionaryValue* dict_ptr = nullptr;
if (!root || !root->GetAsDictionary(&dict_ptr)) {
  NET_LOG(ERROR) << ...;
  return nullptr;
}

root.release();
return make_scoped_ptr(dict_ptr);

[Olli Raula, 2015-09-09 13:32:30]

Hmm, thanks for advices. I did them but we have an error. release() outputs a
value and it have to be used somehow, now building fails because of that. What
we should do with it?

[pneubeck (no reviews), 2015-09-09 13:35:12]

you could wrap the release() call with ignore_result from base/macros.h

https://code.google.com/p/chromium/codesearch#chromium/src/base/macros.h&l=171

[Olli Raula, 2015-09-09 14:30:32]

Fixed, thanks

[pneubeck (no reviews), 2015-09-09 14:38:14]

lgtm

[Olli Raula, 2015-09-10 05:32:13]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-09-10 05:32:13]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1328233002/#ps40001
(title: "Add ignore_result's")

[commit-bot: I haz the power, 2015-09-10 05:32:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328233002/40001

[commit-bot: I haz the power, 2015-09-10 05:37:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-10 05:38:21]

Patchset 3 (id:??) landed as
https://crrev.com/c6c44b1595e0a35dd9afe43fc50f5f54c0c13614
Cr-Commit-Position: refs/heads/master@{#348103}

[commit-bot: I haz the power, 2015-09-23 12:07:51]

Patchset 3 (id:??) landed as
https://crrev.com/c6c44b1595e0a35dd9afe43fc50f5f54c0c13614
Cr-Commit-Position: refs/heads/master@{#348103}