Schedule session initialization in MediaKeys.

Source/modules/encryptedmedia/MediaKeySession.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 30 matching lines @@
 {
     return adoptRef(new MediaKeySession(context, cdm, keys));
 }
 
 MediaKeySession::MediaKeySession(ExecutionContext* context, ContentDecryptionModule* cdm, MediaKeys* keys)
     : ContextLifecycleObserver(context)
     , m_keySystem(keys->keySystem())
     , m_asyncEventQueue(GenericEventQueue::create(this))
     , m_session(cdm->createSession(this))
     , m_keys(keys)
-    , m_initializeNewSessionTimer(this, &MediaKeySession::initializeNewSessionTimerFired)
     , m_updateTimer(this, &MediaKeySession::updateTimerFired)
 {
     ScriptWrappable::init(this);
     ASSERT(m_session);
 }
 
 MediaKeySession::~MediaKeySession()
 {
     m_session.clear();
     m_asyncEventQueue->cancelAllEvents();
@@ skipping 11 matching lines @@
 void MediaKeySession::release(ExceptionState& exceptionState)
 {
     m_session->release();
 }
 
 String MediaKeySession::sessionId() const
 {
     return m_session->sessionId();
 }
 
-void MediaKeySession::initializeNewSession(const String& mimeType, Uint8Array* initData)
+void MediaKeySession::initializeNewSession(const String& mimeType, Uint8Array& initData)

[acolwell GONE FROM CHROMIUM, 2014/01/13 19:37:05]

nit: make const&

[xhwang, 2014/01/14 04:04:11]

Done.

 {
-    m_pendingInitializeNewSessionData.append(InitializeNewSessionData(mimeType, initData));
-    m_initializeNewSessionTimer.startOneShot(0);
-}
-
-void MediaKeySession::initializeNewSessionTimerFired(Timer<MediaKeySession>*)
-{
-    ASSERT(m_pendingInitializeNewSessionData.size());
-
-    while (!m_pendingInitializeNewSessionData.isEmpty()) {
-        InitializeNewSessionData data = m_pendingInitializeNewSessionData.takeFirst();
-        // FIXME: Refer to the spec to see what needs to be done in blink.
-        m_session->initializeNewSession(data.mimeType, *data.initData);
-    }
+    m_session->initializeNewSession(mimeType, initData);
 }
 
 void MediaKeySession::update(Uint8Array* response, ExceptionState& exceptionState)
 {
     // From <https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-update>:
     // The update(response) method must run the following steps:
     // 1. If the argument is null or an empty array, throw an INVALID_ACCESS_ERR.
     if (!response || !response->length()) {
         exceptionState.throwDOMException(InvalidAccessError, String::format("The response argument provided is %s.", response ? "an empty array" : "invalid"));
         return;
     }
 
     // 2. If the session is not in the PENDING state, throw an INVALID_STATE_ERR.
     // FIXME: Implement states in MediaKeySession.
 
     // 3. Schedule a task to handle the call, providing response.
     m_pendingKeys.append(response);

[ddorwin, 2014/01/13 20:20:57]

m_pendingUpdate[Message]s?

[xhwang, 2014/01/14 04:04:11]

Done.

-    m_updateTimer.startOneShot(0);
+
+    if (!m_updateTimer.isActive())
+        m_updateTimer.startOneShot(0);
 }
 
 void MediaKeySession::updateTimerFired(Timer<MediaKeySession>*)
 {
     ASSERT(m_pendingKeys.size());
 
     while (!m_pendingKeys.isEmpty()) {
         RefPtr<Uint8Array> pendingKey = m_pendingKeys.takeFirst();
 
         // NOTE: Continued from step 2. of MediaKeySession::update()
@@ skipping 56 matching lines @@
 {
     return EventTargetNames::MediaKeySession;
 }
 
 ExecutionContext* MediaKeySession::executionContext() const
 {
     return ContextLifecycleObserver::executionContext();
 }
 
 }