Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1328193003: Construct Range rather than Constant when typing integers. (Closed)

Created:
5 years, 3 months ago by neis
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Construct Range rather than Constant when typing integers. Also clarify some comments. R=jarin@chromium.org BUG= Committed: https://crrev.com/08dc43947d14e4b02809400222f23ff6afb6852a Cr-Commit-Position: refs/heads/master@{#30708}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M src/compiler/typer.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M src/types.h View 3 chunks +15 lines, -13 lines 0 comments Download
M src/types.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jarin
lgtm
5 years, 3 months ago (2015-09-14 08:50:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328193003/20001
5 years, 3 months ago (2015-09-14 08:58:07 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 09:23:27 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 09:23:42 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08dc43947d14e4b02809400222f23ff6afb6852a
Cr-Commit-Position: refs/heads/master@{#30708}

Powered by Google App Engine
This is Rietveld 408576698