Implement referrerpolicy attr for iframes

Source/core/html/HTMLIFrameElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 14 matching lines @@
 #include "config.h"
 #include "core/html/HTMLIFrameElement.h"
 
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "core/CSSPropertyNames.h"
 #include "core/HTMLNames.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLDocument.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/layout/LayoutIFrame.h"
+#include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 inline HTMLIFrameElement::HTMLIFrameElement(Document& document)
     : HTMLFrameElementBase(iframeTag, document)
     , m_didLoadNonEmptyDocument(false)

[Yoav Weiss, 2015/09/08 09:55:08]

m_referrerPolicy should be initialized regardless of runtime flag.

     , m_sandbox(DOMSettableTokenList::create(this))
 {
 }
 
 DEFINE_NODE_FACTORY(HTMLIFrameElement)
 
 DEFINE_TRACE(HTMLIFrameElement)
 {
     visitor->trace(m_sandbox);
     HTMLFrameElementBase::trace(visitor);
@@ skipping 60 matching lines @@
     if (name == nameAttr) {
         if (inDocument() && document().isHTMLDocument() && !isInShadowTree()) {
             HTMLDocument& document = toHTMLDocument(this->document());
             document.removeExtraNamedItem(m_name);
             document.addExtraNamedItem(value);
         }
         m_name = value;
     } else if (name == sandboxAttr) {
         m_sandbox->setValue(value);
         UseCounter::count(document(), UseCounter::SandboxViaIFrame);
+    } else if (RuntimeEnabledFeatures::referrerPolicyAttributeEnabled() && name == referrerpolicyAttr) {
+        m_referrerPolicy = ReferrerPolicyDefault;
+        if (!value.isNull())
+            SecurityPolicy::referrerPolicyFromString(value, &m_referrerPolicy);
     } else {
         HTMLFrameElementBase::parseAttribute(name, value);
     }
 }
 
 bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style)
 {
     return isURLAllowed() && HTMLElement::layoutObjectIsNeeded(style);
 }
 
@@ skipping 33 matching lines @@
 
 void HTMLIFrameElement::valueChanged()
 {
     String invalidTokens;
     setSandboxFlags(m_sandbox->value().isNull() ? SandboxNone : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens));
     if (!invalidTokens.isNull())
         document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens));
     setSynchronizedLazyAttribute(sandboxAttr, m_sandbox->value());
 }
 
+bool HTMLIFrameElement::referrerPolicyAttribute(ReferrerPolicy* policy)

[Yoav Weiss, 2015/09/08 09:55:08]

Like I wrote at the caller site, it'd be better to just return the policy and
check the runtime flag at the caller.

[estark, 2015/09/08 14:40:34]

Done.

[estark, 2015/09/08 14:40:34]

Done.

+{
+    if (!RuntimeEnabledFeatures::referrerPolicyAttributeEnabled())
+        return false;
+
+    *policy = m_referrerPolicy;
+    return true;
 }
+}