Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328093006: [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. BUG= Committed: https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d Cr-Commit-Position: refs/heads/master@{#347816}

Patch Set 1 #

Patch Set 2 : fix StoryRunnerTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jbudorick
5 years, 3 months ago (2015-09-08 20:00:16 UTC) #2
nednguyen
lgtm
5 years, 3 months ago (2015-09-08 20:57:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328093006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328093006/1
5 years, 3 months ago (2015-09-08 20:58:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/104369)
5 years, 3 months ago (2015-09-08 21:34:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328093006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328093006/20001
5 years, 3 months ago (2015-09-08 21:43:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 22:48:33 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d Cr-Commit-Position: refs/heads/master@{#347816}
5 years, 3 months ago (2015-09-08 22:49:11 UTC) #12
jbudorick
5 years, 3 months ago (2015-09-08 23:51:25 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1314953011/ by jbudorick@chromium.org.

The reason for reverting is: somehow managed to break Linux Tests:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/306....

Powered by Google App Engine
This is Rietveld 408576698