Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132803013: DevTools: [CSS] setStyleSheetText to work with inline stylesheets. (Closed)

Created:
6 years, 10 months ago by lushnikov
Modified:
6 years, 10 months ago
Reviewers:
apavlov, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

This patch improves setStyleSheetText command so that it is able to set text for the stylesheets, generated for "style" attribute. BUG=341506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167008

Patch Set 1 #

Patch Set 2 : fix testcase #

Total comments: 2

Patch Set 3 : address @apavlov comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -4 lines) Patch
A LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html View 1 chunk +78 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/styles/styles-new-API-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
ptal
6 years, 10 months ago (2014-02-06 17:51:06 UTC) #1
lushnikov
On 2014/02/06 17:51:06, lushnikov wrote: > ptal ping?
6 years, 10 months ago (2014-02-11 11:46:00 UTC) #2
apavlov
Please disambiguate the issue subject so that it does not use "synthetic" (which we use ...
6 years, 10 months ago (2014-02-12 11:52:31 UTC) #3
lushnikov
Address comments https://codereview.chromium.org/132803013/diff/30001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/132803013/diff/30001/Source/core/inspector/InspectorStyleSheet.cpp#newcode1665 Source/core/inspector/InspectorStyleSheet.cpp:1665: return false; On 2014/02/12 11:52:32, apavlov wrote: ...
6 years, 10 months ago (2014-02-12 12:21:23 UTC) #4
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 10 months ago (2014-02-12 12:22:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/132803013/150001
6 years, 10 months ago (2014-02-12 12:22:30 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 13:35:05 UTC) #7
Message was sent while issue was closed. 
Change committed as 167008

Powered by Google App Engine
This is Rietveld 408576698