Attempt to recover sync token for managed user once we detected that sync auth fails.

Attempt to recover sync token for managed user once we detected that sync auth fails.

BUG=332032
R=nkostylev@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250980

[Nikita (slow), 2014-02-07 09:51:48]

lgtm

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/auth_sync_observer.cc (right):

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/auth_sync_observer.cc:65: old_status ==
User::OAUTH2_TOKEN_STATUS_VALID) {
This needs to be checked as 
old_status != User::OAUTH2_TOKEN_STATUS_INVALID

since first generation supervised users didn't have their token status set
correctly and it was OAUTH_TOKEN_STATUS_UNKNOWN.

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/auth_sync_observer.cc:67:
UserManager::Get()->GetSupervisedUserManager()->LoadSupervisedUserToken(
nit: Please add UMA metric to track this.

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/auth_sync_observer.cc:76: LOG(ERROR) <<
nit: Please add UMA metric to track this.

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/supervised_user_manager_impl.cc (right):

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/supervised_user_manager_impl.cc:82: if
(!base::ReadFileToString(token_file, &token)) {
nit: Drop {}

https://codereview.chromium.org/132803012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/supervised_user_manager_impl.cc:441:
base::FilePath profile_dir = ProfileHelper::GetProfilePathByUserIdHash(
profile->GetPath() should work too.

[Nikita (slow), 2014-02-10 16:44:50]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-02-10 16:45:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/132803012/70001

[commit-bot: I haz the power, 2014-02-10 18:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-10 18:23:17]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, check_deps2git, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, events_unittests, google_apis_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Denis Kuznetsov (DE-MUC), 2014-02-13 10:27:11]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-02-13 10:27:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/132803012/340001

[commit-bot: I haz the power, 2014-02-13 14:16:50]

Change committed as 250980