Work on GN iOS GYP generation.

Work on GN iOS GYP generation.

This adds support for more XCODE flags to GN's GYP generator which XCode needs to be happy. With this patch, XCode can actually compile targets now and seems to do basically the right things (to the limited extent of my understanding).

TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248840

[brettw, 2014-02-04 08:42:29]

Sadly there's much more weird hardcoding in this patch.

There's likely to be one more pass after this, I still need to verify all the
flags are correct, but at least this compiles in both xcode and ninja.

[brettw, 2014-02-05 04:08:52]

I'm TBRing this so I can start work on the next phase.

[brettw, 2014-02-05 04:11:51]

Committed patchset #2 manually as r248840 (presubmit successful).

[Nico, 2014-02-05 04:19:35]

sorry, lgtm

(It's "Xcode", not "XCODE" or "XCode" :-P)

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
File tools/gn/gyp_binary_target_writer.cc (right):

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:142: // switch, and the following one to be
the value.
I think both -isysroot foo and -isysroot=foo might be valid, not sure though.

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:479: Indent(indent + kExtraIndent) <<
"'TARGETED_DEVICE_FAMILY': '1,2',\n";
Hm, hardcoding this stuff in the gn binary seems somewhat unfortunate.

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:495: Indent(indent + kExtraIndent) <<
"'ARCHS': [ 'x86_64' ],\n";
remoting sets ARCHS to both i386, x86_64 I think (because it's a "preferences
pane plugin", meaning it's loaded into the "system preferences" process, and
that can be either 32 or 64 bit depending on OS X version.

[brettw, 2014-02-05 04:29:30]

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
File tools/gn/gyp_binary_target_writer.cc (right):

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:479: Indent(indent + kExtraIndent) <<
"'TARGETED_DEVICE_FAMILY': '1,2',\n";
On 2014/02/05 04:19:35, Nico wrote:
> Hm, hardcoding this stuff in the gn binary seems somewhat unfortunate.

Yeah. Is there a command line option this maps to? I'm currently under the
impression that this just tells something to Xcode which possibly writes this
into some file. If there's some meaningful way to express this in the pure GN or
Ninja build, I can write a converted, but I didn't see anything that
corresponded.

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:495: Indent(indent + kExtraIndent) <<
"'ARCHS': [ 'x86_64' ],\n";
On 2014/02/05 04:19:36, Nico wrote:
> remoting sets ARCHS to both i386, x86_64 I think (because it's a "preferences
> pane plugin", meaning it's loaded into the "system preferences" process, and
> that can be either 32 or 64 bit depending on OS X version.

Okay, we'll have to deal with that when it comes up, probably starting with how
to express this in the pure GN build.

[Nico, 2014-02-05 04:55:27]

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
File tools/gn/gyp_binary_target_writer.cc (right):

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:479: Indent(indent + kExtraIndent) <<
"'TARGETED_DEVICE_FAMILY': '1,2',\n";
On 2014/02/05 04:29:30, brettw wrote:
> On 2014/02/05 04:19:35, Nico wrote:
> > Hm, hardcoding this stuff in the gn binary seems somewhat unfortunate.
> 
> Yeah. Is there a command line option this maps to? I'm currently under the
> impression that this just tells something to Xcode which possibly writes this
> into some file. If there's some meaningful way to express this in the pure GN
or
> Ninja build, I can write a converted, but I didn't see anything that
> corresponded.

I think this is written into the UIDeviceFamily plist key in the resulting app
bundle; it doesn't map to a flag.

Eventually, GN or something it calls will have to have a concept for this (when
it does bundling and writes Info.plist files), so maybe invent a name for it and
set it in a gni file and convert that thing to TARGETED_DEVICE_FAMILY?

On the other hand, it's unlikely to change for chrome/ios.

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:495: Indent(indent + kExtraIndent) <<
"'ARCHS': [ 'x86_64' ],\n";
On 2014/02/05 04:29:30, brettw wrote:
> On 2014/02/05 04:19:36, Nico wrote:
> > remoting sets ARCHS to both i386, x86_64 I think (because it's a
"preferences
> > pane plugin", meaning it's loaded into the "system preferences" process, and
> > that can be either 32 or 64 bit depending on OS X version.
> 
> Okay, we'll have to deal with that when it comes up, probably starting with
how
> to express this in the pure GN build.

The commit message on how this is done in gyp/ninja is fairly detailed:
https://code.google.com/p/gyp/source/detail?r=1692

[brettw, 2014-02-05 06:18:53]

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
File tools/gn/gyp_binary_target_writer.cc (right):

https://codereview.chromium.org/132803008/diff/30001/tools/gn/gyp_binary_targ...
tools/gn/gyp_binary_target_writer.cc:495: Indent(indent + kExtraIndent) <<
"'ARCHS': [ 'x86_64' ],\n";
I *think* the way to do this in GN would be to just make a "fat" mac toolchain
and everything should work fine. The main issue would be to find the best way to
invoke this (like maybe have a target in the default toolchain with the name
"remoting" that references the one in the other toolchain and copies the result
to the main build dir).