Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 132803005: SkOnce: add option to call another cleanup function once at exit. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
hal.canary, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SkOnce: add option to call another cleanup function once at exit. Use this to clean up empty SkData and SkPathRef. Current leaks: Leaked SkRefCntBase: 40 Leaked SkFlattenable: 32 Leaked SkPixelRef: 32 Leaked SkMallocPixelRef: 32 Leaked SkFontConfigInterface: 1 Leaked SkWeakRefCnt: 1 Leaked SkTypeface: 1 Leaked SkFontMgr: 1 Leaked SkDataTable: 3 Leaked SkImage: 1 Leaked ???: 1 Leaked ???: 1 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13180

Patch Set 1 #

Patch Set 2 : = NULL #

Patch Set 3 : apply the same to SkScaledImageCache #

Patch Set 4 : doc #

Patch Set 5 : add static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -34 lines) Patch
M include/core/SkData.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkOnce.h View 1 2 3 4 chunks +9 lines, -4 lines 0 comments Download
M include/core/SkPathRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkData.cpp View 1 1 chunk +8 lines, -6 lines 0 comments Download
M src/core/SkPathRef.cpp View 1 1 chunk +7 lines, -5 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M tests/OnceTest.cpp View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 11 months ago (2014-01-24 19:18:18 UTC) #1
hal.canary
lgtm
6 years, 11 months ago (2014-01-24 19:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/132803005/160001
6 years, 11 months ago (2014-01-24 19:50:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 132803005-160001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-24 19:50:57 UTC) #4
mtklein
6 years, 11 months ago (2014-01-24 19:56:44 UTC) #5
reed1
lgtm
6 years, 11 months ago (2014-01-24 21:31:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/132803005/160001
6 years, 11 months ago (2014-01-24 21:33:08 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildTests http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=1356
6 years, 11 months ago (2014-01-24 21:44:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/132803005/290001
6 years, 11 months ago (2014-01-24 22:19:15 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 22:38:50 UTC) #10
Message was sent while issue was closed.
Change committed as 13180

Powered by Google App Engine
This is Rietveld 408576698