Issue 1328013002: Add early out back to Node::updateDistribution().

Issue 1328013002: Add early out back to Node::updateDistribution(). (Closed)

Created:
5 years, 3 months ago by esprehn

Modified:
5 years, 3 months ago

Reviewers:
hayato, dglazkov, ojan

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add early out back to Node::updateDistribution(). It was walking the children of the root (usually the <head> and <body>) on every call even if nothing was dirty. This meant each call was 5 branches plus a trace macro, the macro often being more expensive than the no-op work. Lets instead abort early if nothing is dirty and skip the trace macro when possible to avoid polluting traces with trace overhead spam. BUG=527982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201838

Patch Set 1 #

Patch Set 2 : do it right. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	Source/core/dom/Node.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	Source/core/editing/EditingTestBase.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download