Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1328003002: [heap] No leakage of objects-visiting.h outside of heap. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-scavenger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] No leakage of objects-visiting.h outside of heap. This prevents the internal objects-visiting.h to be usable outisde of the "heap" directory. The static object visitation is only usefull within the GC and is now properly encapsulated. R=hpayer@chromium.org,mlippautz@chromium.org Committed: https://crrev.com/a0bc7651aba787426bae456a9217fd80b03b55c5 Cr-Commit-Position: refs/heads/master@{#30716}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M src/heap/heap.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.h View 4 chunks +6 lines, -7 lines 0 comments Download
M src/objects.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-04 12:54:39 UTC) #2
Michael Lippautz
lgtm
5 years, 3 months ago (2015-09-04 13:40:10 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-14 09:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328003002/20001
5 years, 3 months ago (2015-09-14 12:27:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 12:28:39 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 12:28:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0bc7651aba787426bae456a9217fd80b03b55c5
Cr-Commit-Position: refs/heads/master@{#30716}

Powered by Google App Engine
This is Rietveld 408576698