Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1327993003: Web MIDI: update blink API for open(), clear(), and close() backends (Closed)

Created:
5 years, 3 months ago by Takashi Toyoshima
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web MIDI: update blink API for open(), clear(), and close() backends To implement MIDIPort#open(), #clear(), and #close(), let's add new interfaces to implement backends for them. Backend will be implemented in chromium side soon. Once it gets ready, I'll update Web MIDI IDLs and modules/webmidi implementations to use these interface to be up to date. BUG=471793, 471798 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public/platform/WebMIDIAccessor.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Takashi Toyoshima
PTAL
5 years, 3 months ago (2015-09-04 07:03:51 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-09-06 23:50:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327993003/1
5 years, 3 months ago (2015-09-07 06:06:45 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 06:51:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201860

Powered by Google App Engine
This is Rietveld 408576698