Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327983003: Remove CJBig2_Module::JBig2_Error and friends. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -236 lines) Patch
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 38 chunks +0 lines, -90 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 38 chunks +0 lines, -138 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Module.h View 1 chunk +0 lines, -8 lines 3 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h File core/src/fxcodec/jbig2/JBig2_Module.h (left): https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h#oldcode28 core/src/fxcodec/jbig2/JBig2_Module.h:28: virtual void JBig2_Error(const FX_CHAR* format, ...) {} The methods, ...
5 years, 3 months ago (2015-09-04 00:47:51 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h File core/src/fxcodec/jbig2/JBig2_Module.h (right): https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h#newcode10 core/src/fxcodec/jbig2/JBig2_Module.h:10: class CJBig2_Module { why is it called CJBig2_Module ...
5 years, 3 months ago (2015-09-04 00:52:44 UTC) #3
Lei Zhang
https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h File core/src/fxcodec/jbig2/JBig2_Module.h (right): https://codereview.chromium.org/1327983003/diff/1/core/src/fxcodec/jbig2/JBig2_Module.h#newcode10 core/src/fxcodec/jbig2/JBig2_Module.h:10: class CJBig2_Module { On 2015/09/04 00:52:44, Tom Sepez wrote: ...
5 years, 3 months ago (2015-09-04 00:56:42 UTC) #4
Lei Zhang
5 years, 3 months ago (2015-09-04 01:00:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6087a2f18e0c779c1bae62812801cee98fe8a09d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698