Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132793014: Change streamsPrivate to use an IDL definition file. (Closed)

Created:
6 years, 10 months ago by Zachary Kuznia
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Change streamsPrivate to use an IDL definition file. BUG=343006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251048

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -51 lines) Patch
M chrome/common/extensions/api/api.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/streams_private.idl View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
D chrome/common/extensions/api/streams_private.json View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Zachary Kuznia
Please take a look
6 years, 10 months ago (2014-02-12 20:12:04 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/132793014/diff/1/chrome/common/extensions/api/api.gyp File chrome/common/extensions/api/api.gyp (right): https://codereview.chromium.org/132793014/diff/1/chrome/common/extensions/api/api.gyp#newcode107 chrome/common/extensions/api/api.gyp:107: 'streams_private.idl', you should put this up in "non_compiled_schema_files" ...
6 years, 10 months ago (2014-02-12 20:35:16 UTC) #2
Zachary Kuznia
https://codereview.chromium.org/132793014/diff/1/chrome/common/extensions/api/api.gyp File chrome/common/extensions/api/api.gyp (right): https://codereview.chromium.org/132793014/diff/1/chrome/common/extensions/api/api.gyp#newcode107 chrome/common/extensions/api/api.gyp:107: 'streams_private.idl', On 2014/02/12 20:35:16, kalman wrote: > you should ...
6 years, 10 months ago (2014-02-12 23:17:06 UTC) #3
Zachary Kuznia
thestig, could you do an OWNERS review of: chrome/common/extensions_api_resources.grd
6 years, 10 months ago (2014-02-12 23:19:26 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/132793014/diff/360001/chrome/common/extensions/api/streams_private.idl File chrome/common/extensions/api/streams_private.idl (right): https://codereview.chromium.org/132793014/diff/360001/chrome/common/extensions/api/streams_private.idl#newcode1 chrome/common/extensions/api/streams_private.idl:1: // Copyright (c) 2014 The Chromium Authors. All ...
6 years, 10 months ago (2014-02-13 01:30:17 UTC) #5
Zachary Kuznia
https://codereview.chromium.org/132793014/diff/360001/chrome/common/extensions/api/streams_private.idl File chrome/common/extensions/api/streams_private.idl (right): https://codereview.chromium.org/132793014/diff/360001/chrome/common/extensions/api/streams_private.idl#newcode1 chrome/common/extensions/api/streams_private.idl:1: // Copyright (c) 2014 The Chromium Authors. All rights ...
6 years, 10 months ago (2014-02-13 01:36:03 UTC) #6
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 10 months ago (2014-02-13 01:36:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/132793014/720002
6 years, 10 months ago (2014-02-13 01:37:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 04:19:39 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263157
6 years, 10 months ago (2014-02-13 04:19:41 UTC) #10
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 10 months ago (2014-02-13 16:13:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/132793014/720002
6 years, 10 months ago (2014-02-13 16:14:57 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 16:18:08 UTC) #13
Message was sent while issue was closed. 
Change committed as 251048

Powered by Google App Engine
This is Rietveld 408576698