Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Issue 132793003: Change avd.py script to let developers point to emulator SDK. (Closed)

Created:
6 years, 11 months ago by navabi
Modified:
6 years, 11 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Change avd.py script to let developers point to emulator SDK. The emulator sdk root is now downloaded into the source tree (and .gitingore'd). That means that doing a clobber on the src directory will delete the emulator SDK downloaded by build/android/install_emulator_deps.py. This change allows developers to have an emulator SDK located somewhere else that they can point the avd.py script to. Also, some bots will remove the src directory between builds. Rather than make the bots re-download the emulator sdk everytime, this allows them to have an emulator SDK installed somewhere else and point to it. BUG=304129 TBR=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/pylib/constants.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
navabi
This will allow developers and bots to do things like this: ANDROID_EMULATOR_SDK_ROOT=<path_to_local_emulator_sdk> python build/android/avd.py --abi=arm ...
6 years, 11 months ago (2014-01-11 00:04:47 UTC) #1
Maria
lgtm
6 years, 11 months ago (2014-01-11 00:08:35 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-11 00:22:02 UTC) #3
kerz_chromium
lgtm
6 years, 11 months ago (2014-01-13 19:45:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/132793003/1
6 years, 11 months ago (2014-01-13 19:48:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/132793003/1
6 years, 11 months ago (2014-01-13 23:39:48 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 02:27:03 UTC) #7
Message was sent while issue was closed.
Change committed as 244637

Powered by Google App Engine
This is Rietveld 408576698