Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: net/quic/quic_connection.h

Issue 1327923002: Migrates QUIC sessions to a new network when old network is (about to be) disconnected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@home
Patch Set: Rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_session_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index f84be9038fbb2a2fde3da8767470309b3dc3b5fe..051d109a3417224986e9d43ee4cd197e4fc4afed 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -389,6 +389,10 @@ class NET_EXPORT_PRIVATE QuicConnection
// Set the packet writer.
void SetQuicPacketWriter(QuicPacketWriter* writer, bool owns_writer) {
+ DCHECK(writer != nullptr);
+ if (writer_ != nullptr && owns_writer_) {
+ delete writer_;
+ }
writer_ = writer;
owns_writer_ = owns_writer;
}
@@ -505,7 +509,11 @@ class NET_EXPORT_PRIVATE QuicConnection
// Otherwise, it will reschedule the timeout alarm.
void CheckForTimeout();
- // Sends a ping, and resets the ping alarm.
+ // Called when the ping alarm fires. Causes a ping frame to be sent only
+ // if the retransmission alarm is not running.
+ void OnPingTimeout();
+
+ // Sends a ping frame.
void SendPing();
// Sets up a packet with an QuicAckFrame and sends it out.
« no previous file with comments | « net/quic/quic_chromium_client_session_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698