Index: net/quic/quic_chromium_client_session.cc |
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc |
index 41da42047add7588b84242a776871c6df3fac01d..97e8cf0d800e4aa5d1912fc79f65b19576115185 100644 |
--- a/net/quic/quic_chromium_client_session.cc |
+++ b/net/quic/quic_chromium_client_session.cc |
@@ -40,6 +40,11 @@ const int k0RttHandshakeTimeoutMs = 300; |
// IPv6 packets have an additional 20 bytes of overhead than IPv4 packets. |
const size_t kAdditionalOverheadForIPv6 = 20; |
+// Maximum number of Readers that are created for any session due to |
+// connection migration. A new Reader is created every time this endpoint's |
+// IP address changes. |
+const size_t kMaxReadersPerQuicSession = 5; |
+ |
// Histograms for tracking down the crashes from http://crbug.com/354669 |
// Note: these values must be kept in sync with the corresponding values in: |
// tools/metrics/histograms/histograms.xml |
@@ -178,18 +183,11 @@ QuicChromiumClientSession::QuicChromiumClientSession( |
server_id_(server_id), |
require_confirmation_(false), |
stream_factory_(stream_factory), |
- socket_(socket.Pass()), |
transport_security_state_(transport_security_state), |
server_info_(server_info.Pass()), |
num_total_streams_(0), |
task_runner_(task_runner), |
net_log_(BoundNetLog::Make(net_log, NetLog::SOURCE_QUIC_SESSION)), |
- packet_reader_(socket_.get(), |
- clock, |
- this, |
- yield_after_packets, |
- yield_after_duration, |
- net_log_), |
dns_resolution_end_time_(dns_resolution_end_time), |
logger_(new QuicConnectionLogger(this, |
connection_description, |
@@ -198,6 +196,10 @@ QuicChromiumClientSession::QuicChromiumClientSession( |
going_away_(false), |
disabled_reason_(QUIC_DISABLED_NOT), |
weak_factory_(this) { |
+ sockets_.push_back(socket.Pass()); |
+ packet_readers_.push_back(make_scoped_ptr(new QuicPacketReader( |
+ sockets_.back().get(), clock, this, yield_after_packets, |
+ yield_after_duration, net_log_))); |
crypto_stream_.reset( |
crypto_client_stream_factory |
? crypto_client_stream_factory->CreateQuicCryptoClientStream( |
@@ -760,7 +762,10 @@ void QuicChromiumClientSession::OnConnectionClosed(QuicErrorCode error, |
if (!callback_.is_null()) { |
base::ResetAndReturn(&callback_).Run(ERR_QUIC_PROTOCOL_ERROR); |
} |
- socket_->Close(); |
+ |
+ for (auto& socket : sockets_) { |
+ socket->Close(); |
+ } |
QuicSession::OnConnectionClosed(error, from_peer); |
DCHECK(dynamic_streams().empty()); |
CloseAllStreams(ERR_UNEXPECTED); |
@@ -804,7 +809,9 @@ void QuicChromiumClientSession::OnProofVerifyDetailsAvailable( |
} |
void QuicChromiumClientSession::StartReading() { |
- packet_reader_.StartReading(); |
+ for (auto& packet_reader : packet_readers_) { |
+ packet_reader->StartReading(); |
+ } |
} |
void QuicChromiumClientSession::CloseSessionOnError(int error, |
@@ -969,4 +976,20 @@ void QuicChromiumClientSession::OnConnectTimeout() { |
// DCHECK_EQ(0u, GetNumOpenStreams()); |
} |
+bool QuicChromiumClientSession::MigrateToSocket( |
+ scoped_ptr<DatagramClientSocket> socket, |
+ scoped_ptr<QuicPacketReader> reader, |
+ scoped_ptr<QuicPacketWriter> writer) { |
+ DCHECK_EQ(sockets_.size(), packet_readers_.size()); |
+ if (sockets_.size() >= kMaxReadersPerQuicSession) { |
+ return false; |
+ } |
+ connection()->SetQuicPacketWriter(writer.release(), /*owns_writer=*/true); |
Ryan Hamilton
2015/11/18 22:23:35
Can you add a todo here that SetQuicPAcketWriter s
Jana
2015/11/21 02:21:22
Done.
|
+ packet_readers_.push_back(reader.Pass()); |
+ sockets_.push_back(socket.Pass()); |
+ |
+ StartReading(); |
+ return true; |
+} |
+ |
} // namespace net |