Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2165)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1327923002: Migrates QUIC sessions to a new network when old network is (about to be) disconnected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@home
Patch Set: Fixes a few scoped_ptr issues. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 26bf87214a5f65b9053b17b925c4298f9ed04a1d..00c40008b8813178972e922e4d6d53ca76bb6e08 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -197,6 +197,7 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_EQ(1.0f, params.quic_packet_loss_threshold);
EXPECT_FALSE(params.quic_delay_tcp_race);
EXPECT_FALSE(params.quic_close_sessions_on_ip_change);
+ EXPECT_FALSE(params.quic_migrate_sessions_on_net_change);
EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
}
@@ -293,6 +294,24 @@ TEST_F(IOThreadTest, QuicCloseSessionsOnIpChangeFromFieldTrialParams) {
EXPECT_TRUE(params.quic_close_sessions_on_ip_change);
}
+TEST_F(IOThreadTest, QuicCloseSessionsOnIpChangeFromFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["close_sessions_on_ip_change"] = "true";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.quic_close_sessions_on_ip_change);
+}
+
+TEST_F(IOThreadTest, QuicMigrateSessionsOnNetworkChangeFromFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["migrate_sessions_on_network_change"] = "true";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.quic_migrate_sessions_on_network_change);
+}
+
TEST_F(IOThreadTest, PacketLengthFromFieldTrialParams) {
field_trial_group_ = "Enabled";
field_trial_params_["max_packet_length"] = "1450";

Powered by Google App Engine
This is Rietveld 408576698