Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1327913002: Turn a failing assert into an actual check. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 1 chunk +20 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
5 years, 1 month ago (2015-09-03 05:16:05 UTC) #2
Tom Sepez
https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right): https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp#newcode155 core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:155: return nullptr; Do we want to continue with the ...
5 years, 1 month ago (2015-09-03 17:00:56 UTC) #3
Lei Zhang
https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right): https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp#newcode155 core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:155: return nullptr; On 2015/09/03 17:00:56, Tom Sepez wrote: > ...
5 years, 1 month ago (2015-09-03 20:58:34 UTC) #4
Tom Sepez
lgtm
5 years, 1 month ago (2015-09-03 21:11:25 UTC) #5
Lei Zhang
5 years, 1 month ago (2015-09-03 21:13:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
640c395fa9b76552383ccd0c5f4668ea698089f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698