Turn a failing assert into an actual check.

Turn a failing assert into an actual check.

BUG=522131
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/640c395fa9b76552383ccd0c5f4668ea698089f6

[Lei Zhang, 2015-09-03 05:07:46]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-09-03 17:00:56]

https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right):

https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:155: return nullptr;
Do we want to continue with the alternate paths at line 158 to maybe find an
answer if the pObj isn't a dictionary?

[Lei Zhang, 2015-09-03 20:58:34]

https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right):

https://codereview.chromium.org/1327913002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:155: return nullptr;
On 2015/09/03 17:00:56, Tom Sepez wrote:
> Do we want to continue with the alternate paths at line 158 to maybe find an
> answer if the pObj isn't a dictionary?

That's probably better. Done. I made this block the same patter as the one on
line 144.

[Tom Sepez, 2015-09-03 21:11:25]

lgtm

[Lei Zhang, 2015-09-03 21:13:25]

Committed patchset #2 (id:20001) manually as
640c395fa9b76552383ccd0c5f4668ea698089f6 (presubmit successful).