Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1327903004: relnote: QUIC bugfix (and test) for setting smaller receive window size (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Add_num_connections_101619602
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: QUIC bugfix (and test) for setting smaller receive window size under flow-control auto-tuning. Behavior gated by finch tag AFCW, which is currently enabled in canary and dev. Prior to this fix, streams established before the crypto handshake, i.e. headers and crypto, would have their flow control window size become out of sync between client and server, when tags to set smaller initial window sizes were used (kIFW*). It is believed this was causing some flow control deadlocks in the auto-tuning trial. This change also corrects an oversight, adding logic so that kIFW* reduce the initial session flow control window size as well. Merge internal change: 101695854 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -41 lines) Patch
M net/quic/quic_flow_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +39 lines, -12 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 10 chunks +93 lines, -29 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-10 01:42:11 UTC) #1
Ryan Hamilton
5 years, 3 months ago (2015-09-10 14:28:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698