Issue 132783002: Fix for AudioEncoder crash when using cast.streaming API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132783002: Fix for AudioEncoder crash when using cast.streaming API. (Closed)

Created:
6 years, 11 months ago by miu

Modified:
6 years, 11 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for AudioEncoder crash when using cast.streaming API. A subtle race condition was occurring between the destruction of the AudioBus and a while-loop's final dereferencing of the audio_bus pointer before breaking. BUG=332623 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244288

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	media/cast/audio_sender/audio_encoder.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

On 2014/01/09 22:59:53, miu wrote: > hclam: PTAL. Feel free to check commit if ell-gee-tee-em. ...

6 years, 11 months ago (2014-01-10 20:04:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/132783002/1

6 years, 11 months ago (2014-01-10 20:09:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/132783002/1

6 years, 11 months ago (2014-01-10 23:39:39 UTC) #4

Message was sent while issue was closed.

Change committed as 244288

Expand Messages | Collapse Messages