Issue 1327793003: Move WebCache memory dump provider to blink for sub-allocation edges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1327793003: Move WebCache memory dump provider to blink for sub-allocation edges. (Closed)

Created:
5 years, 3 months ago by ssid

Modified:
5 years, 2 months ago

Reviewers:
Primiano Tucci (use gerrit)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move WebCache memory dump provider to blink for sub-allocation edges. The memory cache in blink allocates from PartitionAlloc for encoded data. To add sub-allocation edges to appropriate allocators, the dump provider is moved into blink. This CL adds WebCache memory dump provider in blink, which was removed from chrome side in this CL: www.crrev.com/1304073006. BUG=520842

Patch Set 1 #

Patch Set 2 : Nits. #

Patch Set 3 : Fixes. #

Patch Set 4 : Nits. #

Patch Set 5 : Fixes. #

Patch Set 6 : Just add webcache. #

Patch Set 7 : Nit. #

Patch Set 8 : Moving branch. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -8 lines)			Patch
M	third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/BitmapImage.h	View	1 2 3 4 5 6 7	3 chunks	+5 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/BitmapImage.cpp	View	1 2 3 4 5 6 7	4 chunks	+16 lines, -0 lines	0 comments	Download
A +	third_party/WebKit/Source/web/WebCacheMemoryDumpProvider.h	View	1 2 3 4 5 6 7	1 chunk	+10 lines, -7 lines	0 comments	Download
A	third_party/WebKit/Source/web/WebCacheMemoryDumpProvider.cpp	View	1 2 3 4 5 6 7	1 chunk	+97 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebKit.cpp	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/web.gypi	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/wtf/Partitions.h	View	1 2 3 4 5 6 7	2 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/wtf/Partitions.cpp	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/public/platform/WebProcessMemoryDump.h	View	1 2 3 4 5 6 7	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

PTAL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages