Added and implemented URLRequest::GetTotalSentBytes.

net/url_request/url_request_http_job_unittest.cc

Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 50557ec35497702a79e4f81993f1d9a5c036d47b..8e77bd9defc846b1ff14de557494e7e9f12c4672 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -135,6 +135,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
 
   EXPECT_TRUE(request->status().is_success());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(51, request->GetTotalReceivedBytes());

[mmenke, 2015/09/04 15:21:49]

Can't we just calculate the received bytes from the mock reads.  We should also
add write expectations, and test those as well - seems more robust.

[sclittle, 2015/09/04 22:03:10]

Done.

   EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
 }
 
@@ -158,6 +160,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
 
   EXPECT_TRUE(request->status().is_success());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(12, request->GetTotalReceivedBytes());
   EXPECT_EQ(12, network_delegate_.total_network_bytes_received());
 }
 
@@ -182,6 +186,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest, TestContentLengthAbortedRequest) {
 
   EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(51, request->GetTotalReceivedBytes());
   EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
 }
 
@@ -207,6 +213,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
 
   EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(51, request->GetTotalReceivedBytes());
   EXPECT_EQ(51, network_delegate_.total_network_bytes_received());
 }
 
@@ -237,6 +245,9 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
 
   EXPECT_TRUE(request->status().is_success());
   EXPECT_EQ(12, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(51, request->GetTotalReceivedBytes());

[mmenke, 2015/09/04 15:21:49]

Think these are worth a comment (Basically the opposite of the next comment -
should not include the redirect)

[sclittle, 2015/09/04 22:03:10]

Done.

+  // Should include the redirect as well as the final response.
   EXPECT_EQ(107, network_delegate_.total_network_bytes_received());

[mmenke, 2015/09/04 15:21:49]

We should do the same for bytes sent, to make sure the redirect is handled
properly.

[sclittle, 2015/09/04 22:03:10]

Yeah, that will come later in a separate CL when I add and implement
NetworkDelegate::OnNetworkBytesSent.

 }
 
@@ -257,6 +268,9 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
+  EXPECT_EQ(0, request->received_response_content_length());
+  EXPECT_EQ(137, request->GetTotalSentBytes());
+  EXPECT_EQ(19, request->GetTotalReceivedBytes());
   EXPECT_EQ(19, network_delegate_.total_network_bytes_received());
 }
 
@@ -276,6 +290,9 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(URLRequestStatus::CANCELED, request->status().status());
+  EXPECT_EQ(0, request->received_response_content_length());
+  EXPECT_EQ(0, request->GetTotalSentBytes());
+  EXPECT_EQ(0, request->GetTotalReceivedBytes());
   EXPECT_EQ(0, network_delegate_.total_network_bytes_received());
 }