Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1327743004: [runtime] Move AtomicIsLockFree out of Runtime class. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Move AtomicIsLockFree out of Runtime class. R=binji@chromium.org Committed: https://crrev.com/a14d2dfaa5aa68cea3231f2ceb7bc05ff86ac09e Cr-Commit-Position: refs/heads/master@{#30663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M src/runtime/runtime.h View 2 chunks +0 lines, -25 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Motivation: I am trying to reduce the amount of grab-bag functions on the {Runtime} class. ...
5 years, 3 months ago (2015-09-09 14:25:41 UTC) #1
binji
lgtm. There are long-term plans to use it elsewhere but it is fine here for ...
5 years, 3 months ago (2015-09-09 16:40:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327743004/1
5 years, 3 months ago (2015-09-09 17:06:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 17:13:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 17:13:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a14d2dfaa5aa68cea3231f2ceb7bc05ff86ac09e
Cr-Commit-Position: refs/heads/master@{#30663}

Powered by Google App Engine
This is Rietveld 408576698