content/browser/service_worker/embedded_worker_instance.h - Issue 1327723005: Fix crash during EmbeddedWorkerInstance startup sequence failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 1327723005: Fix crash during EmbeddedWorkerInstance startup sequence failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix asan Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | content/browser/service_worker/embedded_worker_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance.h

diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h

index 7bece691cd392a4ebf2b5129611e9a6db8f55a70..e3e977162d56d5c9e4f3f13db135e55fbb9ce98a 100644

--- a/content/browser/service_worker/embedded_worker_instance.h

+++ b/content/browser/service_worker/embedded_worker_instance.h

@@ -231,7 +231,13 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {

int line_number,

const GURL& source_url);

+ // Resets all running state. After this function is called, |status_| is

+ // STOPPED.

void ReleaseProcess();

+ // Called when the startup sequence failed. Calls ReleaseProcess() and invokes

kinuko 2015/09/13 08:41:11 nit: ... via |callback|. ?

+ void OnStartFailed(const StatusCallback& callback,

+ ServiceWorkerStatusCode status);

base::WeakPtr<ServiceWorkerContextCore> context_;

scoped_refptr<EmbeddedWorkerRegistry> registry_;

« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | content/browser/service_worker/embedded_worker_instance.cc » ('J')