Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 1327723005: Fix crash during EmbeddedWorkerInstance startup sequence failures (Closed) Base URL:
Patch Set: fix asan Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 7bece691cd392a4ebf2b5129611e9a6db8f55a70..e3e977162d56d5c9e4f3f13db135e55fbb9ce98a 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -231,7 +231,13 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
int line_number,
const GURL& source_url);
+ // Resets all running state. After this function is called, |status_| is
void ReleaseProcess();
+ // Called when the startup sequence failed. Calls ReleaseProcess() and invokes
+ // |callback| with |status|. May destroy |this|.
kinuko 2015/09/13 08:41:11 nit: ... via |callback|. ?
+ void OnStartFailed(const StatusCallback& callback,
+ ServiceWorkerStatusCode status);
base::WeakPtr<ServiceWorkerContextCore> context_;
scoped_refptr<EmbeddedWorkerRegistry> registry_;

Powered by Google App Engine
This is Rietveld 408576698