Issue 1327713003: Properly handle CR LF in LineScanner.

Issue 1327713003: Properly handle CR LF in LineScanner. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/string_scanner@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Properly handle CR LF in LineScanner. R=rnystrom@google.com Committed: https://github.com/dart-lang/string_scanner/commit/27d20a3ed710eafbbe26d5c694e583e703ad5916

Patch Set 1 #

Total comments: 4

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -15 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/line_scanner.dart	View	6 chunks	+22 lines, -7 lines	4 comments	Download
M	pubspec.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/line_scanner_test.dart	View	5 chunks	+37 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1327713003/diff/1/lib/src/line_scanner.dart File lib/src/line_scanner.dart (right): https://codereview.chromium.org/1327713003/diff/1/lib/src/line_scanner.dart#newcode54 lib/src/line_scanner.dart:54: if (_betweenCRLF) newlines.removeLast(); How about hoisting this to ...

5 years, 3 months ago (2015-09-02 00:07:24 UTC) #2

nweiz

https://codereview.chromium.org/1327713003/diff/1/lib/src/line_scanner.dart File lib/src/line_scanner.dart (right): https://codereview.chromium.org/1327713003/diff/1/lib/src/line_scanner.dart#newcode54 lib/src/line_scanner.dart:54: if (_betweenCRLF) newlines.removeLast(); On 2015/09/02 00:07:24, Bob Nystrom wrote: ...

5 years, 3 months ago (2015-09-02 00:10:57 UTC) #3

nweiz

5 years, 3 months ago (2015-09-02 00:11:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
27d20a3ed710eafbbe26d5c694e583e703ad5916 (presubmit successful).

Expand Messages | Collapse Messages