Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327713002: DevTools: move didFireTimer and didHandleEvent to DOMDebugger (Closed)

Created:
5 years, 3 months ago by yurys
Modified:
5 years, 3 months ago
Reviewers:
kozy, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: move didFireTimer and didHandleEvent to DOMDebugger Corresponding will* methods are declared on DOMDebugger agent already. BUG=439376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
yurys
5 years, 3 months ago (2015-09-01 22:25:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327713002/1
5 years, 3 months ago (2015-09-01 22:26:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327713002/1
5 years, 3 months ago (2015-09-01 23:23:32 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-01 23:23:34 UTC) #9
kozy
lgtm
5 years, 3 months ago (2015-09-01 23:25:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327713002/1
5 years, 3 months ago (2015-09-01 23:26:41 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 01:10:18 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201591

Powered by Google App Engine
This is Rietveld 408576698