Blink Plugins: Remove Shadow DOM Plugin Placeholder remnants.

Blink Plugins: Remove Shadow DOM Plugin Placeholder remnants.

BUG=524115
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201651

[tommycli, 2015-09-01 19:53:24]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 19:53:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327693002/20001

[tommycli, 2015-09-01 20:32:47]

tommycli@chromium.org changed reviewers:
+ pdr@chromium.org

[tommycli, 2015-09-01 20:32:48]

pdr: PTAL. Removing more dead code.

[commit-bot: I haz the power, 2015-09-01 20:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 20:33:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2015-09-01 21:21:16]

On 2015/09/01 at 20:33:15, commit-bot wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

LGTM

This looks like a real failure though, just need to fix that.

[tommycli, 2015-09-01 22:32:25]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 22:32:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327693002/40001

[tommycli, 2015-09-01 22:32:54]

On 2015/09/01 21:21:16, pdr wrote:
> On 2015/09/01 at 20:33:15, commit-bot wrote:
> > Dry run: Try jobs failed on following builders:
> >   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> LGTM
> 
> This looks like a real failure though, just need to fix that.

pdr: Yes, two more stray lines needed removal in core_generated.gypi

[pdr., 2015-09-01 22:35:48]

On 2015/09/01 at 22:32:54, tommycli wrote:
> On 2015/09/01 21:21:16, pdr wrote:
> > On 2015/09/01 at 20:33:15, commit-bot wrote:
> > > Dry run: Try jobs failed on following builders:
> > >   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > 
> > LGTM
> > 
> > This looks like a real failure though, just need to fix that.
> 
> pdr: Yes, two more stray lines needed removal in core_generated.gypi

LGTM 2

[commit-bot: I haz the power, 2015-09-01 23:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 23:07:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2015-09-01 23:14:21]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-09-01 23:14:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327693002/40001

[commit-bot: I haz the power, 2015-09-01 23:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 23:41:48]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2015-09-02 00:15:25]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 00:15:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327693002/60001

[commit-bot: I haz the power, 2015-09-02 01:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 01:20:27]

Dry run: This issue passed the CQ dry run.

[tommycli, 2015-09-02 16:42:40]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-09-02 16:42:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1327693002/#ps60001
(title: "axe two more lines from core_generated")

[commit-bot: I haz the power, 2015-09-02 16:42:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327693002/60001

[commit-bot: I haz the power, 2015-09-02 16:47:56]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201651