use otutil to get font names

Replace font name table access with standard Skia function.

Remove partial name detection.

Fix typo in custom deserializer to use the sk_ truncated font name.

Committed: https://skia.googlesource.com/skia/+/4f588b5b617da169914e3829389f02883ca70b7c

[_cary, 2015-09-01 20:24:17]

caryclark@chromium.org changed reviewers:
+ bungeman@google.com

[_cary, 2015-09-01 20:24:25]

caryclark@chromium.org changed reviewers:
+ caryclark@chromium.org

[_cary, 2015-09-01 20:24:31]

The CQ bit was checked by caryclark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 20:24:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327683002/40001

[commit-bot: I haz the power, 2015-09-01 20:24:39]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-09-02 02:24 UTC

[bungeman-skia, 2015-09-01 20:47:51]

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
File src/utils/SkWhitelistTypefaces.cpp (right):

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:43: SkTypeface::LocalizedStrings* nameIter =
I think this might be better as

SkAutoTUref<SkTypeface::LocalizedStrings> nameIter(
    SkOTUtils::LocalizedStrings_NameTable::CreateForFamilyNames(*tf);

since one should call 'unref' on it to clean it up.

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:47: fontNameStr =
familyNameLocalized.fString.c_str();
Is there a reason for the '.c_str()'? It seems

fontNameStr = familyNameLocalized.fString

should do the same thing, but just refcount the underlying data rather than copy
it.

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:55: nameIter =
SkOTUtils::LocalizedStrings_NameTable::CreateForFamilyNames(*tf);
Does all of this (down to the '}') belong in the '#if WHITELIST_DEBUG'? It
doesn't seem to have any effect on the outcome, except for printing out the
names. I'm assuming the intention here is to just return -1 as the fall-through,
and the rest here is debug code.

[commit-bot: I haz the power, 2015-09-02 02:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 02:24:03]

Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[caryclark, 2015-09-02 11:45:15]

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
File src/utils/SkWhitelistTypefaces.cpp (right):

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:43: SkTypeface::LocalizedStrings* nameIter =
On 2015/09/01 20:47:51, bungeman1 wrote:
> I think this might be better as
> 
> SkAutoTUref<SkTypeface::LocalizedStrings> nameIter(
>     SkOTUtils::LocalizedStrings_NameTable::CreateForFamilyNames(*tf);
> 
> since one should call 'unref' on it to clean it up.

Done.

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:47: fontNameStr =
familyNameLocalized.fString.c_str();
On 2015/09/01 20:47:51, bungeman1 wrote:
> Is there a reason for the '.c_str()'? It seems
> 
> fontNameStr = familyNameLocalized.fString
> 
> should do the same thing, but just refcount the underlying data rather than
copy
> it.

Done.

https://codereview.chromium.org/1327683002/diff/40001/src/utils/SkWhitelistTy...
src/utils/SkWhitelistTypefaces.cpp:55: nameIter =
SkOTUtils::LocalizedStrings_NameTable::CreateForFamilyNames(*tf);
On 2015/09/01 20:47:51, bungeman1 wrote:
> Does all of this (down to the '}') belong in the '#if WHITELIST_DEBUG'? It
> doesn't seem to have any effect on the outcome, except for printing out the
> names. I'm assuming the intention here is to just return -1 as the
fall-through,
> and the rest here is debug code.

Done.

[caryclark, 2015-09-02 11:45:19]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-09-02 11:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327683002/60001

[commit-bot: I haz the power, 2015-09-02 11:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 11:45:33]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[caryclark, 2015-09-02 12:09:47]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 12:09:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327683002/60001

[commit-bot: I haz the power, 2015-09-02 12:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 12:15:29]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-09-02 15:07:50]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-09-02 15:07:51]

lgtm

[commit-bot: I haz the power, 2015-09-02 15:08:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327683002/60001

[commit-bot: I haz the power, 2015-09-02 15:08:35]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4f588b5b617da169914e3829389f02883ca70b7c