Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: content/browser/media/capture/aura_window_capture_machine.cc

Issue 1327673006: Crash fix for window closed during Aura window capture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/capture/aura_window_capture_machine.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/capture/aura_window_capture_machine.cc
diff --git a/content/browser/media/capture/aura_window_capture_machine.cc b/content/browser/media/capture/aura_window_capture_machine.cc
index 1da55061fd7a4986517f01f27f4619f3e788dcb1..f4db9601edae6af546c612719920902abe57f37a 100644
--- a/content/browser/media/capture/aura_window_capture_machine.cc
+++ b/content/browser/media/capture/aura_window_capture_machine.cc
@@ -456,12 +456,12 @@ void AuraWindowCaptureMachine::OnWindowBoundsChanged(
&AuraWindowCaptureMachine::UpdateCaptureSize, AsWeakPtr()));
}
-void AuraWindowCaptureMachine::OnWindowDestroyed(aura::Window* window) {
+void AuraWindowCaptureMachine::OnWindowDestroying(aura::Window* window) {
miu 2015/09/03 20:46:44 Note: I changed this from OnWindowDestroyed() to O
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- Stop(base::Bind(&base::DoNothing));
+ InternalStop(base::Bind(&base::DoNothing));
- oracle_proxy_->ReportError("OnWindowDestroyed()");
+ oracle_proxy_->ReportError("OnWindowDestroying()");
}
void AuraWindowCaptureMachine::OnWindowAddedToRootWindow(
« no previous file with comments | « content/browser/media/capture/aura_window_capture_machine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698