Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1327673006: Crash fix for window closed during Aura window capture. (Closed)

Created:
5 years, 3 months ago by miu
Modified:
5 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash fix for window closed during Aura window capture. The root cause was that while the code *did* have a WindowObserver to stop capture when the window was destroyed, it erroneously did so by posting a task that would be executed too late. This change makes the stop operation synchronous. BUG=513103 Committed: https://crrev.com/14d3aff86097e05ccf6319114f1711b2129762e9 Cr-Commit-Position: refs/heads/master@{#347266}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
miu
sergeyu: PTAL (simple crash fix). https://codereview.chromium.org/1327673006/diff/1/content/browser/media/capture/aura_window_capture_machine.cc File content/browser/media/capture/aura_window_capture_machine.cc (right): https://codereview.chromium.org/1327673006/diff/1/content/browser/media/capture/aura_window_capture_machine.cc#newcode459 content/browser/media/capture/aura_window_capture_machine.cc:459: void AuraWindowCaptureMachine::OnWindowDestroying(aura::Window* window) { ...
5 years, 3 months ago (2015-09-03 20:46:44 UTC) #2
Sergey Ulanov
lgtm
5 years, 3 months ago (2015-09-03 22:13:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327673006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327673006/1
5 years, 3 months ago (2015-09-03 22:14:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 22:20:41 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 22:21:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14d3aff86097e05ccf6319114f1711b2129762e9
Cr-Commit-Position: refs/heads/master@{#347266}

Powered by Google App Engine
This is Rietveld 408576698