Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: Source/devtools/front_end/security/SecurityModel.js

Issue 1327593005: Link to the mixed content filter from security panel (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/security/SecurityModel.js
diff --git a/Source/devtools/front_end/security/SecurityModel.js b/Source/devtools/front_end/security/SecurityModel.js
index d0058571ee2c60a7bbfa0066d805e7ef4088d897..c07a0322ced8677504344cde6c81acb9ee838c6a 100644
--- a/Source/devtools/front_end/security/SecurityModel.js
+++ b/Source/devtools/front_end/security/SecurityModel.js
@@ -65,22 +65,7 @@ WebInspector.SecurityDispatcher.prototype = {
*/
securityStateChanged: function(securityState, explanations, mixedContentStatus, schemeIsCryptographic)
{
- var data = {"securityState": securityState, "explanations": explanations || []};
- if (schemeIsCryptographic && mixedContentStatus) {
- if (mixedContentStatus.ranInsecureContent) {
- explanations.push({
- "securityState": mixedContentStatus.ranInsecureContentStyle,
- "summary": WebInspector.UIString("Active Mixed Content"),
- "description": WebInspector.UIString("You have recently allowed insecure content (such as scripts or iframes) to run on this site.")
- });
- } else if (mixedContentStatus.displayedInsecureContent) {
- explanations.push({
- "securityState": mixedContentStatus.displayedInsecureContentStyle,
- "summary": WebInspector.UIString("Mixed Content"),
- "description": WebInspector.UIString("The site includes HTTP resources.")
- });
- }
- }
+ var data = {"securityState": securityState, "explanations": explanations || [], "mixedContentStatus": mixedContentStatus, "schemeIsCryptographic": schemeIsCryptographic};
pfeldman 2015/09/03 23:48:48 It is always better to define a class / typedef it
estark 2015/09/04 02:45:30 Not sure if I did this right, PTAL.
this._model.dispatchEventToListeners(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, data);
}
}

Powered by Google App Engine
This is Rietveld 408576698