Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: Source/devtools/front_end/security/SecurityPanel.js

Issue 1327593003: DevTools: [security] open certificate viewer from devtools security overview (blink) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/security/SecurityPanel.js
diff --git a/Source/devtools/front_end/security/SecurityPanel.js b/Source/devtools/front_end/security/SecurityPanel.js
index 166d8aa84258b5fcb5123b40355ac0b759f95b4e..0cbf679d48a7617b9c982f3c55dd2b72351e54e4 100644
--- a/Source/devtools/front_end/security/SecurityPanel.js
+++ b/Source/devtools/front_end/security/SecurityPanel.js
@@ -356,6 +356,20 @@ WebInspector.SecurityMainView.prototype = {
var text = explanationSection.createChild("div", "security-section-text");
text.createChild("div", "security-section-title").textContent = explanation.summary;
text.createChild("div", "security-explanation").textContent = explanation.description;
+ if ("certificateId" in explanation) {
+ var certificateAnchor = text.createChild("div", "security-certificate-id link");
dgozman 2015/09/02 19:02:41 div -> a?
pfeldman 2015/09/02 21:29:13 Needs to be block.
+ certificateAnchor.textContent = WebInspector.UIString("View certificate");
+ certificateAnchor.href = "";
+ certificateAnchor.addEventListener("click", showCertificaite, false);
+ }
+ /**
+ * @param {!Event} e
+ */
+ function showCertificaite(e)
lgarron 2015/09/02 01:43:38 Nit: s/showCertificaite/showCertificate (I'd actu
pfeldman 2015/09/02 21:29:13 Done.
+ {
+ e.consume();
+ WebInspector.targetManager.mainTarget().networkManager.showCertificateViewer(/** @type {number} */ (explanation.certificateId));
pfeldman 2015/09/02 01:34:14 We might want to pass the this._target from the se
lgarron 2015/09/02 01:43:38 I would personally add showCertificate() to WebIns
dgozman 2015/09/02 19:02:41 Should not matter actually.
+ }
},
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/security/mainView.css » ('j') | Source/devtools/front_end/security/mainView.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698