DevTools: [security] open certificate viewer from devtools security overview (blink)

Source/devtools/front_end/security/SecurityPanel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.PanelWithSidebar}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.SecurityPanel = function()
@@ skipping 338 matching lines @@
      */
     _addExplanation: function(explanation)
     {
         var explanationSection = this._securityExplanations.createChild("div", "security-section");
         explanationSection.classList.add("security-explanation");
 
         explanationSection.createChild("div", "lock-icon").classList.add("lock-icon-" + explanation.securityState);
         var text = explanationSection.createChild("div", "security-section-text");
         text.createChild("div", "security-section-title").textContent = explanation.summary;
         text.createChild("div", "security-explanation").textContent = explanation.description;
+        if ("certificateId" in explanation) {
+            var certificateAnchor = text.createChild("div", "security-certificate-id link");

[dgozman, 2015/09/02 19:02:41]

div -> a?

[pfeldman, 2015/09/02 21:29:13]

Needs to be block.

+            certificateAnchor.textContent = WebInspector.UIString("View certificate");
+            certificateAnchor.href = "";
+            certificateAnchor.addEventListener("click", showCertificaite, false);
+        }
+        /**
+         * @param {!Event} e
+         */
+        function showCertificaite(e)

[lgarron, 2015/09/02 01:43:38]

Nit: s/showCertificaite/showCertificate

(I'd actually also prefer showCertificateViewer(), but I don't have strong
reasons.)

[pfeldman, 2015/09/02 21:29:13]

Done.

+        {
+            e.consume();
+            WebInspector.targetManager.mainTarget().networkManager.showCertificateViewer(/** @type {number} */ (explanation.certificateId));

[pfeldman, 2015/09/02 01:34:14]

We might want to pass the this._target from the security panel here.

[lgarron, 2015/09/02 01:43:38]

I would personally add showCertificate() to WebInspector.SecurityPanel, then
pass `panel` into the WebInspector.SecurityMainView constructor and call:

certificateAnchor.addEventListener("click", this._panel.showCertificateViewer,
false);

[dgozman, 2015/09/02 19:02:41]

Should not matter actually.

+        }
     },
 
     /**
      * @param {!SecurityAgent.SecurityState} newSecurityState
      * @param {!Array<!SecurityAgent.SecurityStateExplanation>} explanations
      */
     updateSecurityState: function(newSecurityState, explanations)
     {
         // Remove old state.
         // It's safe to call this even when this._securityState is undefined.
@@ skipping 157 matching lines @@
 
         var valueDiv = row.createChild("div");
         if (value instanceof HTMLDivElement) {
             valueDiv.appendChild(value);
         } else {
             valueDiv.textContent = value;
         }
     }
 }