Issue 1327573002: make build_sdk more incremental

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1327573002: make build_sdk more incremental (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly

Modified:
5 years, 3 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

make build_sdk more incremental saves about 3s off a typical rebuild where nothing changed R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/10f621d1788e9344b2170b68f4a5187c8beddb58

Patch Set 2 : #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -27 lines)			Patch
M	lib/src/compiler.dart	View	1	1 chunk	+14 lines, -0 lines	1 comment	Download
M	tool/build_sdk.sh	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	tool/patch_sdk.dart	View	1	3 chunks	+46 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

https://codereview.chromium.org/1327573002/diff/20001/lib/src/compiler.dart File lib/src/compiler.dart (right): https://codereview.chromium.org/1327573002/diff/20001/lib/src/compiler.dart#newcode176 lib/src/compiler.dart:176: // TODO(jmesserly): full incremental support would avoid checking as ...

5 years, 3 months ago (2015-08-31 23:43:08 UTC) #2

Jennifer Messerly

5 years, 3 months ago (2015-09-02 15:43:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
10f621d1788e9344b2170b68f4a5187c8beddb58 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1327573002: make build_sdk more incremental (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages