Implemented QuicHttpStream::GetTotalSentBytes.

net/quic/quic_http_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_http_stream.h"
 
 #include "base/callback_helpers.h"
 #ifdef TEMP_INSTRUMENTATION_468529
 #include "base/debug/alias.h"
 #endif
@@ skipping 23 matching lines @@
       session_error_(OK),
       was_handshake_confirmed_(session->IsCryptoHandshakeConfirmed()),
       stream_(nullptr),
       request_info_(nullptr),
       request_body_stream_(nullptr),
       priority_(MINIMUM_PRIORITY),
       response_info_(nullptr),
       response_status_(OK),
       response_headers_received_(false),
       closed_stream_received_bytes_(0),
+      closed_stream_sent_bytes_(0),
       user_buffer_len_(0),
       weak_factory_(this) {
   DCHECK(session_);
   session_->AddObserver(this);
 }
 
 QuicHttpStream::~QuicHttpStream() {
 #ifdef TEMP_INSTRUMENTATION_468529
   liveness_ = DEAD;
   stack_trace_ = base::debug::StackTrace();
@@ skipping 204 matching lines @@
 
 int64 QuicHttpStream::GetTotalReceivedBytes() const {
   if (stream_) {
     return stream_->stream_bytes_read();
   }
 
   return closed_stream_received_bytes_;
 }
 
 int64_t QuicHttpStream::GetTotalSentBytes() const {
-  // TODO(sclittle): Implement this for real. http://crbug.com/518897.
-  return 0;
+  if (stream_) {

[bengr, 2015/09/01 17:16:06]

Is it always the case that stream_ is non-null when bytes have been written?

[sclittle, 2015/09/02 00:06:23]

What do you mean? |stream_| will be null after it's been closed, which is why
|closed_stream_sent_bytes_| exists.

+    return stream_->stream_bytes_written();
+  }
+
+  return closed_stream_sent_bytes_;
 }
 
 bool QuicHttpStream::GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const {
   // TODO(mmenke):  Figure out what to do here.
   return true;
 }
 
 void QuicHttpStream::GetSSLInfo(SSLInfo* ssl_info) {
   DCHECK(stream_);
   session_->GetSSLInfo(ssl_info);
@@ skipping 267 matching lines @@
 }
 
 SpdyMajorVersion QuicHttpStream::GetSpdyVersion() {
   return SpdyUtils::GetSpdyVersionForQuicVersion(stream_->version());
 }
 
 void QuicHttpStream::ResetStream() {
   if (!stream_)
     return;
   closed_stream_received_bytes_ = stream_->stream_bytes_read();
+  closed_stream_sent_bytes_ = stream_->stream_bytes_written();
   stream_ = nullptr;
 }
 
 void QuicHttpStream::CrashIfInvalid() const {
 #ifdef TEMP_INSTRUMENTATION_468529
   Liveness liveness = liveness_;
 
   if (liveness == ALIVE)
     return;
 
   // Copy relevant variables onto the stack to guarantee they will be available
   // in minidumps, and then crash.
   base::debug::StackTrace stack_trace = stack_trace_;
 
   base::debug::Alias(&liveness);
   base::debug::Alias(&stack_trace);
 
   CHECK_EQ(ALIVE, liveness);
 #endif
 }
 
 }  // namespace net