Implemented QuicHttpStream::GetTotalSentBytes.

Implemented QuicHttpStream::GetTotalSentBytes.

Based on https://codereview.chromium.org/1314783007/.

This CL implements QuicHttpStream::GetTotalSentBytes, currently only
including the size of the payload.

BUG=518897
Committed: https://crrev.com/1edeeb2849552e8d06a782836bb4d6d0cafd5d9d
Cr-Commit-Position: refs/heads/master@{#347015}

[sclittle, 2015-08-31 22:24:49]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, rch@chromium.org

[Ryan Hamilton, 2015-09-01 14:26:09]

lgtm

[bengr, 2015-09-01 17:16:06]

lgtm, with a few questions/minor suggestions.

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream.cc
File net/quic/quic_http_stream.cc (right):

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream.c...
net/quic/quic_http_stream.cc:269: if (stream_) {
Is it always the case that stream_ is non-null when bytes have been written?

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
net/quic/quic_http_stream_test.cc:392: //
QuicHttpStream::GetTotalSent/ReceivedBytes currently only includes the
Does "currently" suggest a TODO?

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
net/quic/quic_http_stream_test.cc:603:
EXPECT_EQ(static_cast<int64_t>(strlen(kUploadData) * 2),
Why *2?

[sclittle, 2015-09-02 00:06:23]

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream.cc
File net/quic/quic_http_stream.cc (right):

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream.c...
net/quic/quic_http_stream.cc:269: if (stream_) {
On 2015/09/01 17:16:06, bengr wrote:
> Is it always the case that stream_ is non-null when bytes have been written?

What do you mean? |stream_| will be null after it's been closed, which is why
|closed_stream_sent_bytes_| exists.

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
net/quic/quic_http_stream_test.cc:392: //
QuicHttpStream::GetTotalSent/ReceivedBytes currently only includes the
On 2015/09/01 17:16:06, bengr wrote:
> Does "currently" suggest a TODO?

Sure, added a TODO in quic_http_stream.cc.

https://codereview.chromium.org/1327533002/diff/1/net/quic/quic_http_stream_t...
net/quic/quic_http_stream_test.cc:603:
EXPECT_EQ(static_cast<int64_t>(strlen(kUploadData) * 2),
On 2015/09/01 17:16:06, bengr wrote:
> Why *2?

Because 2 chunks of kUploadData were sent with the request.

[sclittle, 2015-09-02 18:36:17]

Patchset #3 (id:40001) has been deleted

[sclittle, 2015-09-02 19:42:00]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2015-09-02 19:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1327533002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2015-09-02 19:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327533002/60001

[commit-bot: I haz the power, 2015-09-02 20:46:18]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-02 20:47:38]

Patchset 3 (id:??) landed as
https://crrev.com/1edeeb2849552e8d06a782836bb4d6d0cafd5d9d
Cr-Commit-Position: refs/heads/master@{#347015}